Closed MichaelDeBoey closed 2 years ago
@MichaelDeBoey Thanks for the PR. Need any help? (I know it's still in Draft, but couldn't help taking a look.)
@benkimpel I think I'm mostly waiting on the devDeps to support ESLint 8.x now 🤔
@benkimpel I think I'm mostly waiting on the devDeps to support ESLint 8.x now thinking
Great! :+1:
Hey @MichaelDeBoey, you have some linting errors
@dangreenisrael Should I just ignore no-shadow
rule on these lines?
They're reporting that i's already there on their own line
18:19 error 'StatementType' is already declared in the upper scope on line 18 column 19 no-shadow
40:19 error 'PaddingType' is already declared in the upper scope on line 40 column 19 no-shadow
I'm cool with that. Will you just add a comment in the code explaining why we are making an exception to the rule?
@MichaelDeBoey I want to give @dangreenisrael a chance to review, but this will probably merge tomorrow.
@MichaelDeBoey I want to give @dangreenisrael a chance to review, but this will probably merge tomorrow.
I'm going to take Dan's comment as tacit approval for a merge. He'll have to trigger the release to npm, though.
@dangreenisrael Can you please trigger the release?
3.1.0
has been shipped. Thanks so much for your work @MichaelDeBoey!
ESLint v8.0.0 is released 🎉
devDependency compatibility with ESLint 8:
@typescript-eslint/eslint-plugin
(https://github.com/typescript-eslint/typescript-eslint/issues/3738)v5.0.0
@typescript-eslint/parser
(https://github.com/typescript-eslint/typescript-eslint/issues/3738)v5.0.0
eslint-config-airbnb-base
(https://github.com/airbnb/javascript/issues/2478)v15.0.0
eslint-config-prettier
(https://github.com/prettier/eslint-config-prettier/issues/200)eslint-plugin-import
(https://github.com/import-js/eslint-plugin-import/issues/2211)v2.25.0
eslint-plugin-jest
(https://github.com/jest-community/eslint-plugin-jest/issues/881)v24.4.1
v24.4.2
v25.0.0
v25.0.4
v25.0.5
v25.1.0
eslint-plugin-prettier
(https://github.com/prettier/eslint-plugin-prettier/issues/427)BREAKING CHANGE: Requires Node@^12.22.0 || ^14.17.0 || >=16.0.0
Closes #107