dangreenisrael / eslint-plugin-jest-formatting

ESLint rules for formatting test suites written for jest.
MIT License
156 stars 13 forks source link

feat: support ESLint 8.x #108

Closed MichaelDeBoey closed 2 years ago

MichaelDeBoey commented 3 years ago

ESLint v8.0.0 is released 🎉

devDependency compatibility with ESLint 8:


BREAKING CHANGE: Requires Node@^12.22.0 || ^14.17.0 || >=16.0.0

Closes #107

benkimpel commented 3 years ago

@MichaelDeBoey Thanks for the PR. Need any help? (I know it's still in Draft, but couldn't help taking a look.)

MichaelDeBoey commented 3 years ago

@benkimpel I think I'm mostly waiting on the devDeps to support ESLint 8.x now 🤔

benkimpel commented 3 years ago

@benkimpel I think I'm mostly waiting on the devDeps to support ESLint 8.x now thinking

Great! :+1:

dangreenisrael commented 2 years ago

Hey @MichaelDeBoey, you have some linting errors

MichaelDeBoey commented 2 years ago

@dangreenisrael Should I just ignore no-shadow rule on these lines? They're reporting that i's already there on their own line

18:19  error  'StatementType' is already declared in the upper scope on line 18 column 19  no-shadow
40:19  error  'PaddingType' is already declared in the upper scope on line 40 column 19    no-shadow
dangreenisrael commented 2 years ago

I'm cool with that. Will you just add a comment in the code explaining why we are making an exception to the rule?

benkimpel commented 2 years ago

@MichaelDeBoey I want to give @dangreenisrael a chance to review, but this will probably merge tomorrow.

benkimpel commented 2 years ago

@MichaelDeBoey I want to give @dangreenisrael a chance to review, but this will probably merge tomorrow.

I'm going to take Dan's comment as tacit approval for a merge. He'll have to trigger the release to npm, though.

MichaelDeBoey commented 2 years ago

@dangreenisrael Can you please trigger the release?

dangreenisrael commented 2 years ago

3.1.0 has been shipped. Thanks so much for your work @MichaelDeBoey!