search

dangreenisrael / eslint-plugin-jest-formatting

ESLint rules for formatting test suites written for jest.
MIT License
156 stars 13 forks source link

[BUG] `src/something/tests.tsx` doesnt get looked at #120

Open pvinis opened 11 months ago

pvinis commented 11 months ago

Describe the bug We have files like src/something/tests.tsx and the rules of this repo don't run there!

Expected behavior The rules should run on there too.

Additional context I noticed that on https://github.com/dangreenisrael/eslint-plugin-jest-formatting/blob/master/src/index.ts#L141-L151 there is a list of filenames, and ours is not in there. I could make a PR to add these, but also I think we can probably remove the overrides bit from this file, and put the rules one level up, as a sibling to plugins, and everything will work well.

Normally (and we too) people have a testMatch on the jest config, so it already knows all the test files of the project. No need to have special detection on this repo.

Let me know if I should make a PR to add our test or if I should make a PR removing the overrides.

benkimpel commented 8 months ago

Sorry for the late reply. Go for it!

benkimpel commented 8 months ago

Although, now that I think about it... @pvinis, I believe you should be able to override these file patterns from the plugin in your own setup. IIRC this was just something we did as a convenience and as a way to make sure that the plugin doesn't run against source files out of the box.

However, it's been a while since I've worked in this ecosystem at this point, so I will defer to @dangreenisrael, @hockeybuggy, or any of the other collaborators on this project. (I should probably remove myself from the project.)