search

dangreenisrael / eslint-plugin-jest-formatting

ESLint rules for formatting test suites written for jest.
MIT License
156 stars 13 forks source link

Fix examples for padding-before-test-blocks rule #45

Closed tamias closed 5 years ago

tamias commented 5 years ago

The same code example appears as incorrect code and twice as correct code for the padding-before-test-blocks rule.

Removed the extraneous code examples.

Also, fixed a typo in the text.

benkimpel commented 5 years ago

Hey @tamias!

I'm just a collaborator on the project, but I think I can safely speak for @dangreenisrael when I say, "Thanks for contributing!" and "good eye!".

There's an open PR here that might clobber the changes in your PR. I think we'll want to wait and see how @dangreenisrael wants to proceed. I think the PR I referenced will probably merge soon.

dangreenisrael commented 5 years ago

Hey @tamias Thanks so much for opening this PR.

As @benkimpel mentioned, he has a major PR underway that changes a lot of stuff under the hood. I believe he has fixed some of the issues with the docs in the process.

Would you mind sitting on this PR for a little bit until after his pr lands? (It should be soon)

benkimpel commented 5 years ago

@tamias @dangreenisrael

Well, looks like I caught the original doc issue in my PR, but I made another!! @tamias, the fix is yours if you'd like to open a separate PR. It's an easy one.

This md file has the wrong paths. :cry:

Sorry, @dangreenisrael. I have failed you.

dangreenisrael commented 5 years ago

lol. No worries @benkimpel

@tamias I'm going to open an issue and tag you in it.

dangreenisrael commented 5 years ago

https://github.com/dangreenisrael/eslint-plugin-jest-formatting/issues/48