search

dangreenisrael / eslint-plugin-jest-formatting

ESLint rules for formatting test suites written for jest.
MIT License
156 stars 13 forks source link

[BUG] Rules not properly marked as deprecated #75

Closed dimitropoulos closed 4 years ago

dimitropoulos commented 4 years ago

Eslint has an explicit mechanism for marking a rule as deprecated: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/eslint/index.d.ts#L295.

I maintain eslint-config-intense which uses eslint-find-rules during upgrades of configs and plugins. During a usage I noticed all the previous rules which are deprecated have not been marked as such.

NOTE: Deprecated rules are found by looking at the metadata of the rule definition. All core rules and many plugin rules use this flag to indicate deprecated rules. But if you find a plugin that does not mark their rules as deprecated in the rule metadata, please file a pull request with that project.

  • eslint-find-rules readme.md
dangreenisrael commented 4 years ago

Thanks so much for this @dimitropoulos. I've merged your PR but there seems to be an issue in the deployment job. I will look into it tonight and try to have v1.1.1 shipped by tomorrow.

dangreenisrael commented 4 years ago

@dimitropoulos v1.1.1 is deployed. Thanks again for your PR.