search

dangreenisrael / eslint-plugin-jest-formatting

ESLint rules for formatting test suites written for jest.
MIT License
156 stars 13 forks source link

[BUG] undocumented rule: (padding-around-all) #80

Closed dimitropoulos closed 4 years ago

dimitropoulos commented 4 years ago

The following rule is undocumented: https://github.com/dangreenisrael/eslint-plugin-jest-formatting/blob/master/src/index.ts#L133.

I would expect it to be mentioned on the readme, and linked back to a .md file that simply lists all the other rules that it controls. I'll leave it up to you the maintainers of this project as to whether those rules that padding-around-all controls also make mention that they can be configured in this way.

benkimpel commented 4 years ago

@dimitropoulos Any interest in doing a PR for this? For your last question, I'd vote that rules that are included in padding-around-all don't need to mention it in their own documentation. That could get burdensome from a maintenance perspective or easily out of sync.

dimitropoulos commented 4 years ago

not really but it only took like 60 seconds to do and I was waiting for kubernetes to spin up, haha: https://github.com/dangreenisrael/eslint-plugin-jest-formatting/pull/81

benkimpel commented 4 years ago

😆 it was 60 more seconds than I had at the time. Your work is appreciated. Thank you

dangreenisrael commented 4 years ago

Thanks so much @dimitropoulos