search

dangreenisrael / eslint-plugin-jest-formatting

ESLint rules for formatting test suites written for jest.
MIT License
156 stars 13 forks source link

[BUG] .nvmrc file needs an update #97

Closed xiaoyunyang closed 3 years ago

xiaoyunyang commented 3 years ago

Describe the bug

The .nvmrc file currently states v8.10.0 but this causes the following error when running this project.

error eslint-plugin-jest-formatting@2.0.1: 
The engine "node" is incompatible with this module. 

Expected version "^10.12.0 || >=12.0.0". Got "8.10.0"
error Found incompatible module.

The fix is simple. Fix the node version in .nvmrc. But which version should be specified? 🤔

To Reproduce Steps to reproduce the behavior:

  1. clone this repo
  2. run yarn

Expected behavior No error should happen when you run yarn.

benkimpel commented 3 years ago

Hi @xiaoyunyang. Good catch. Thanks. I think I'd actually vote to remove that file all together. Any thoughts on it, @dangreenisrael?

dangreenisrael commented 3 years ago

Oh no! Great catch. I've got no problem with dropping .nvmrc.

@xiaoyunyang Do you want to open a PR dropping it?

benkimpel commented 3 years ago

Deleting things is my favorite part of programming so I'm happy to do it if it comes down to it. But we should give @xiaoyunyang a chance in case their passion for deleting things is even greater than my own.

dangreenisrael commented 3 years ago

@benkimpel Looks like @xiaoyunyang doesn't want it. Any interest in taking this on?

benkimpel commented 3 years ago

@dangreenisrael yeah, sounds good. I'll take care of it tomorrow morning.

dangreenisrael commented 3 years ago

Thanks @benkimpel