search

danguilherme / ng-cli-pug-loader

:sparkles: Angular schematics to add .pug to your project
GNU General Public License v3.0
56 stars 17 forks source link

v0.2.2 has wrong NPM dependencies #30

Closed matheo closed 3 years ago

matheo commented 4 years ago

Instead

"dependencies": {
  "@angular-devkit/core": "^0.5.13",
  "@angular-devkit/schematics": "^0.5.13"
},

you should define something like

"peerDependencies": {
  "@angular-devkit/core": ">=0.5.13 < 0.900.0",
  "@angular-devkit/schematics": ">=0.5.13 < 0.900.0"
},

because your script is supposed to modify the files of those packages, already installed, and defining them as dependencies, you're adding @angular-devkit/core@0.5.13 to our angular projects, instead just work with the existing files.

Thanks for the great work.

danguilherme commented 4 years ago

Hey, thanks for pointing it out! Will check this asap.

matheo commented 4 years ago

and if you release 0.2.3, it will fix the projects including ~0.2.2 or ^0.2.0 ;)

matheo commented 4 years ago

@danguilherme now that I think about it you could simplify the current requirements given that the webpack loaders haven't new recent versions, you could define apply-loader and pug-loader as dependencies. Maybe it's convenient to define pug as peerDependency too, but it can be installed from this library too. I may build a PR soon ;)

matheo commented 3 years ago

Closed because this library got unmaintained