dangvd / ksmoothdock

A cool desktop panel for KDE Plasma 5
56 stars 7 forks source link

Freeze on constant switch with 4 virtual desktops with different wallpapers #38

Closed andrecbarros closed 7 years ago

andrecbarros commented 7 years ago

First, thank you, really nice dock.

My distro is openSUSE Leap 42.2 with KDE repo so that I can use the newest version of KDE Plasma.

I'm still investigating but I suspect that there is a resource leak on wallpaper code. When using it, the system usually becomes unstable after some time, even requiring the KDE DE to be killed.

May I help testing the origin of the problem let me know how you want it to done.

Best regards, André

dangvd commented 7 years ago

Thanks Andre.

About the bug, could you tell me more about:

FYI as KDE Plasma 5 doesn't support different wallpapers on different desktops, I added the feature to KSmoothDock by changing the wallpaper everytime the user changes the desktop. The code to change the wallpaper is simply calling DBus, e.g.:

qdbus org.kde.plasmashell /PlasmaShell org.kde.PlasmaShell.evaluateScript 'var allDesktops = desktops();for (i=0;i<allDesktops.length;i++) {d = allDesktops[i];d.wallpaperPlugin = "org.kde.image";d.currentConfigGroup = Array("Wallpaper", "org.kde.image", "General");d.writeConfig("Image", "file:///home/username/Pictures/picture.jpg")}'

(well KSmoothDock calls it using D-Bus API, but it's the same)

Also if it's because of resource leak with KDE Plasma 5 wallpaper setting code, I won't be able to do much about it.

andrecbarros commented 7 years ago

Hi,

KDE Frameworks 5.32.0, Apps 17.03.80, Qt 5.8.0.

Above 30 changes in a fast cycle of virtual desktops in my machine consistently triggers the freeze. I ran a clean desktop to see if the behavior would still happens and it did. I will do a last test killing also yakuake.

andrecbarros commented 7 years ago

OK, disabled all components outside plasma desktop and ksmoothdock.

It took around 200 fast cycles to trigger the issue. It is consistent and there is a high possibility of it be a leak somewhere. Will do the test with just KDE plasma.

andrecbarros commented 7 years ago

Just cycling without ksmoothdock and the wallpaper changing does not trigger the issue.

andrecbarros commented 7 years ago

OK, updated to latest Plasma (5.94). The issue is gone.

You can close this issue.

Again, thank you, the dock is great.

andrecbarros commented 7 years ago

OK, lets see, if I only start ksmoothdock and use the keyboard to cycle through the virtual desktops everything keeps running fine but if I cycle through clicking on ksmoothdock it triggers the issue (freeze).

Perhaps, it may help you nail the problem. If there is anything I can do to help, please, let me know.

Regards, André

dangvd commented 7 years ago

Thanks for the detailed test. I still can't reproduce it yet but I will look more into it.

dangvd commented 7 years ago

Hi Andre,

I've made some changes to the code which may or may not help with the issue. If you have some free time, could you pull the latest code from the repo, i.e. $ git pull https://github.com/dangvd/ksmoothdock master and run it and see if it improves?

Thanks, Viet

andrecbarros commented 7 years ago

OK, will do it today. Thanks!

On Thursday, April 20, 2017 1:06 PM, Viet Dang <notifications@github.com> wrote:

Hi Andre,I've made some changes to the code which may or may not help with the issue. If you have some free time, could you pull the latest code from the repo, i.e. $ git pull https://github.com/dangvd/ksmoothdock master and run it and see if it improves?Thanks, Viet— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

dangvd commented 7 years ago

Thanks! Let me know how it goes.

andrecbarros commented 7 years ago

Nice !! No problems so far.

Thank you very much!

dangvd commented 7 years ago

Glad to hear that!