dangwu / Octal

Hacker News Client for iOS
98 stars 2 forks source link

Thumbnails not appearing #281

Closed sageDieu closed 1 year ago

sageDieu commented 1 year ago

Since the update that moved thumbnails to the right side, I've noticed a lot of things that used to have a thumbnail (or maybe at least the touch target indicating it's a link rather than just a text post) now show nothing.

Example in screenshot is the YouTube video

Screenshot 2023-07-12 at 5 44 58 PM

dangwu commented 1 year ago

This is by design. People didn’t like the letter-squares. Text posts are identified by the HN link

On Wed, Jul 12, 2023 at 2:45 PM sageDieu @.***> wrote:

Since the update that moved thumbnails to the right side, I've noticed a lot of things that used to have a thumbnail (or maybe at least the touch target indicating it's a link rather than just a text post) now show nothing.

Example in screenshot is the YouTube video

[image: Screenshot 2023-07-12 at 5 44 58 PM] https://user-images.githubusercontent.com/895847/253107978-77c5f9f8-2b72-4b95-abe3-2ce5371dc982.png

— Reply to this email directly, view it on GitHub https://github.com/dangwu/Octal/issues/281, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABHKY3YNFSFF7PEHHB2UUJLXP4LIDANCNFSM6AAAAAA2ICGFTM . You are receiving this because you are subscribed to this thread.Message ID: @.***>

sageDieu commented 1 year ago

Ok sure, the issue is many posts that are link posts don't have thumbnails now as you can see in my screenshot

On Wed, Jul 12, 2023 at 5:56 PM Daniel Wu @.***> wrote:

This is by design. People didn’t like the letter-squares. Text posts are identified by the HN link

On Wed, Jul 12, 2023 at 2:45 PM sageDieu @.***> wrote:

Since the update that moved thumbnails to the right side, I've noticed a lot of things that used to have a thumbnail (or maybe at least the touch target indicating it's a link rather than just a text post) now show nothing.

Example in screenshot is the YouTube video

[image: Screenshot 2023-07-12 at 5 44 58 PM] < https://user-images.githubusercontent.com/895847/253107978-77c5f9f8-2b72-4b95-abe3-2ce5371dc982.png>

— Reply to this email directly, view it on GitHub https://github.com/dangwu/Octal/issues/281, or unsubscribe < https://github.com/notifications/unsubscribe-auth/ABHKY3YNFSFF7PEHHB2UUJLXP4LIDANCNFSM6AAAAAA2ICGFTM>

. You are receiving this because you are subscribed to this thread.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/dangwu/Octal/issues/281#issuecomment-1633261368, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAG2WZ5VHMZNUWMOBJK5AQTXP4MP3ANCNFSM6AAAAAA2ICGFTM . You are receiving this because you authored the thread.Message ID: @.***>

-- Gabriel Forgie

dangwu commented 1 year ago

Thumbnails are only displayed if the website has an open graph cover image

On Wed, Jul 12, 2023 at 5:12 PM sageDieu @.***> wrote:

Ok sure, the issue is many posts that are link posts don't have thumbnails now as you can see in my screenshot

On Wed, Jul 12, 2023 at 5:56 PM Daniel Wu @.***> wrote:

This is by design. People didn’t like the letter-squares. Text posts are identified by the HN link

On Wed, Jul 12, 2023 at 2:45 PM sageDieu @.***> wrote:

Since the update that moved thumbnails to the right side, I've noticed a lot of things that used to have a thumbnail (or maybe at least the touch target indicating it's a link rather than just a text post) now show nothing.

Example in screenshot is the YouTube video

[image: Screenshot 2023-07-12 at 5 44 58 PM] <

https://user-images.githubusercontent.com/895847/253107978-77c5f9f8-2b72-4b95-abe3-2ce5371dc982.png>

— Reply to this email directly, view it on GitHub https://github.com/dangwu/Octal/issues/281, or unsubscribe <

https://github.com/notifications/unsubscribe-auth/ABHKY3YNFSFF7PEHHB2UUJLXP4LIDANCNFSM6AAAAAA2ICGFTM>

. You are receiving this because you are subscribed to this thread.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/dangwu/Octal/issues/281#issuecomment-1633261368, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AAG2WZ5VHMZNUWMOBJK5AQTXP4MP3ANCNFSM6AAAAAA2ICGFTM>

. You are receiving this because you authored the thread.Message ID: @.***>

-- Gabriel Forgie

— Reply to this email directly, view it on GitHub https://github.com/dangwu/Octal/issues/281#issuecomment-1633357913, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABHKY32AIJHNY2DCBM3MKZDXP44QPANCNFSM6AAAAAA2ICGFTM . You are receiving this because you commented.Message ID: @.***>

sageDieu commented 1 year ago

Alright, maybe this is feedback then to take it back to how it was before?

Personally I liked being able to consistently open links from the feed's thumbnails and in the new interface I'm finding it pretty hard to open any links like these that don't have a thumbnail. It takes several tries for me to get it to open, and I usually end up opening the comments by mistake and then tapping several times on the link before it works because the touch target is so small.

On Wed, Jul 12, 2023 at 8:16 PM Daniel Wu @.***> wrote:

Thumbnails are only displayed if the website has an open graph cover image

On Wed, Jul 12, 2023 at 5:12 PM sageDieu @.***> wrote:

Ok sure, the issue is many posts that are link posts don't have thumbnails now as you can see in my screenshot

On Wed, Jul 12, 2023 at 5:56 PM Daniel Wu @.***> wrote:

This is by design. People didn’t like the letter-squares. Text posts are identified by the HN link

On Wed, Jul 12, 2023 at 2:45 PM sageDieu @.***> wrote:

Since the update that moved thumbnails to the right side, I've noticed a lot of things that used to have a thumbnail (or maybe at least the touch target indicating it's a link rather than just a text post) now show nothing.

Example in screenshot is the YouTube video

[image: Screenshot 2023-07-12 at 5 44 58 PM] <

https://user-images.githubusercontent.com/895847/253107978-77c5f9f8-2b72-4b95-abe3-2ce5371dc982.png>

— Reply to this email directly, view it on GitHub https://github.com/dangwu/Octal/issues/281, or unsubscribe <

https://github.com/notifications/unsubscribe-auth/ABHKY3YNFSFF7PEHHB2UUJLXP4LIDANCNFSM6AAAAAA2ICGFTM>

. You are receiving this because you are subscribed to this thread.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/dangwu/Octal/issues/281#issuecomment-1633261368, or unsubscribe <

https://github.com/notifications/unsubscribe-auth/AAG2WZ5VHMZNUWMOBJK5AQTXP4MP3ANCNFSM6AAAAAA2ICGFTM>

. You are receiving this because you authored the thread.Message ID: @.***>

-- Gabriel Forgie

— Reply to this email directly, view it on GitHub https://github.com/dangwu/Octal/issues/281#issuecomment-1633357913, or unsubscribe < https://github.com/notifications/unsubscribe-auth/ABHKY32AIJHNY2DCBM3MKZDXP44QPANCNFSM6AAAAAA2ICGFTM>

. You are receiving this because you commented.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/dangwu/Octal/issues/281#issuecomment-1633360372, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAG2WZ4Z5HP2GGRHZMEU73TXP446JANCNFSM6AAAAAA2ICGFTM . You are receiving this because you authored the thread.Message ID: @.***>

-- Gabriel Forgie

sageDieu commented 1 year ago

Or add an option for showing whatever generated thumbnail you were showing before, since some people like it and some don't.

On Wed, Jul 12, 2023 at 8:20 PM Gabriel Forgie < @.***> wrote:

Alright, maybe this is feedback then to take it back to how it was before?

Personally I liked being able to consistently open links from the feed's thumbnails and in the new interface I'm finding it pretty hard to open any links like these that don't have a thumbnail. It takes several tries for me to get it to open, and I usually end up opening the comments by mistake and then tapping several times on the link before it works because the touch target is so small.

On Wed, Jul 12, 2023 at 8:16 PM Daniel Wu @.***> wrote:

Thumbnails are only displayed if the website has an open graph cover image

On Wed, Jul 12, 2023 at 5:12 PM sageDieu @.***> wrote:

Ok sure, the issue is many posts that are link posts don't have thumbnails now as you can see in my screenshot

On Wed, Jul 12, 2023 at 5:56 PM Daniel Wu @.***> wrote:

This is by design. People didn’t like the letter-squares. Text posts are identified by the HN link

On Wed, Jul 12, 2023 at 2:45 PM sageDieu @.***> wrote:

Since the update that moved thumbnails to the right side, I've noticed a lot of things that used to have a thumbnail (or maybe at least the touch target indicating it's a link rather than just a text post) now show nothing.

Example in screenshot is the YouTube video

[image: Screenshot 2023-07-12 at 5 44 58 PM] <

https://user-images.githubusercontent.com/895847/253107978-77c5f9f8-2b72-4b95-abe3-2ce5371dc982.png>

— Reply to this email directly, view it on GitHub https://github.com/dangwu/Octal/issues/281, or unsubscribe <

https://github.com/notifications/unsubscribe-auth/ABHKY3YNFSFF7PEHHB2UUJLXP4LIDANCNFSM6AAAAAA2ICGFTM>

. You are receiving this because you are subscribed to this thread.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/dangwu/Octal/issues/281#issuecomment-1633261368,

or

unsubscribe <

https://github.com/notifications/unsubscribe-auth/AAG2WZ5VHMZNUWMOBJK5AQTXP4MP3ANCNFSM6AAAAAA2ICGFTM>

. You are receiving this because you authored the thread.Message ID: @.***>

-- Gabriel Forgie

— Reply to this email directly, view it on GitHub https://github.com/dangwu/Octal/issues/281#issuecomment-1633357913, or unsubscribe < https://github.com/notifications/unsubscribe-auth/ABHKY32AIJHNY2DCBM3MKZDXP44QPANCNFSM6AAAAAA2ICGFTM>

. You are receiving this because you commented.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/dangwu/Octal/issues/281#issuecomment-1633360372, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAG2WZ4Z5HP2GGRHZMEU73TXP446JANCNFSM6AAAAAA2ICGFTM . You are receiving this because you authored the thread.Message ID: @.***>

-- Gabriel Forgie

-- Gabriel Forgie

dangwu commented 1 year ago

Are you a aware that you can change the story destination to URL in settings? Then you can tap anywhere. I'll look into making the URL touch target bigger but no one's complained about it being hard to tap before

sageDieu commented 1 year ago

Ah hadn't seen that setting, that does make it easier. I appreciate you looking into it!

Generally not trying to be annoying/nitpicky but i do think the app was more visually appealing when there weren't random blank rows. Very minor and still really love the app and appreciate your efforts.

On Wed, Jul 12, 2023 at 8:24 PM Daniel Wu @.***> wrote:

Are you a aware that you can change the story destination to URL in settings? Then you can tap anywhere. I'll look into making the URL touch target bigger but no one's complained about it being hard to tap before

— Reply to this email directly, view it on GitHub https://github.com/dangwu/Octal/issues/281#issuecomment-1633365513, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAG2WZ4NXXPH7FNS3GBY6XDXP454NANCNFSM6AAAAAA2ICGFTM . You are receiving this because you authored the thread.Message ID: @.***>

-- Gabriel Forgie

dangwu commented 1 year ago

I've gotten more comments that they prefer the new simpler view. I actually got the idea to remove it from feedback