search

danhale-git / craft

Deploy and manage mc bedrock servers
Apache License 2.0
0 stars 0 forks source link

Errors in commands could leave servers in a broken state #14

Closed danhale-git closed 3 years ago

danhale-git commented 3 years ago

If the run command encounters an error while processing server files we get a container where the mc server process isn't running.

danhale-git commented 3 years ago

This has been mostly addressed but one area which needs sanity checking is the save hold/query/resume. This code should guarantee that the server is not left in a save hold state indefinitely as that will almost certainly cause an issue.

danhale-git commented 3 years ago

The backup process is now fairly robust and an error explicitly informs the user when the server may be in a broken state. I improved that error message slightly https://github.com/danhale-git/craft/commit/f2b51c85092b49376da3aeab07b31c99004c6ce8