search

danhale-git / craft

Deploy and manage mc bedrock servers
Apache License 2.0
0 stars 0 forks source link

Failed commands (`craft cmd time set xxxx`) don't throw an error. #31

Closed danhale-git closed 3 years ago

danhale-git commented 3 years ago

Silent exit not indicating an issue

PS \craft> craft command myserver time set sdasdas
PS \craft>

Server logs:

time set 0600
Set the time to 24600
time set sdasdas
Syntax error: Unexpected "sdasdas": at "/time set >>sdasdas<<"

Consider checking the server logs for errors and reporting them to the user in the cmd package.

danhale-git commented 3 years ago

The appropriate solution is probably to log both the command and the response for the user.

danhale-git commented 3 years ago

https://github.com/danhale-git/craft/commit/d3e5cc0d579b2e06396a10e9d235828970a3a7f2