Currently the craft package provides some high level functions called by the cmd package. Originally the idea was to test that code but it is not yet tested.
PrintServers should probably be part of the CLI logic and perhaps more rigorously tested by integration testing (or whatever ends up testing the CLI code).
SetServerProperties and StartServer should probably be members of server.Server.
It is important to note that this pr introduced support for volumes, making significant changes to the required behaviour of the programs. It is recommended to review those changes before proceeding with this issue. Given the suggested changes above, the server package takes on the responsibility of elegantly handling the two container types (volume and no volume). That is, if the no-volume option is not removed as part of https://github.com/danhale-git/craft/issues/52 (it probably should be).
Currently the
craftpackage provides some high level functions called by thecmdpackage. Originally the idea was to test that code but it is not yet tested.PrintServers should probably be part of the CLI logic and perhaps more rigorously tested by integration testing (or whatever ends up testing the CLI code).
SetServerProperties and StartServer should probably be members of
server.Server.It is important to note that this pr introduced support for volumes, making significant changes to the required behaviour of the programs. It is recommended to review those changes before proceeding with this issue. Given the suggested changes above, the
serverpackage takes on the responsibility of elegantly handling the two container types (volume and no volume). That is, if the no-volume option is not removed as part of https://github.com/danhale-git/craft/issues/52 (it probably should be).