search

danharper / Handlebars-Helpers

A small collection of useful helpers for Handlebars.js
Do What The F*ck You Want To Public License
273 stars 55 forks source link

doesn't work on IE8 #13

Closed xitongzou closed 10 years ago

xitongzou commented 10 years ago

this line...

eR.add('in', function (left, right) { if (!isArray(right)) { right = right.split(','); } return right.indexOf(left) !== -1; });

will break in IE8. You should shim this or use underscore/lodash to fix this.

danharper commented 10 years ago

Personally, I'm not interested in IE8 support, but if you'd like to submit Pull Request, you're welcome to :)

xitongzou commented 10 years ago

I understand if you don't want to add alot of extra code in there for the support, but can you at least make it known in the readme that it will only work for IE9+?

danharper commented 10 years ago

Well, I hadn't tested the library in IE. If you'd like to make a contribution for it, that's fine.