search

danheron / Heron.MudCalendar

Calendar component for MudBlazor
MIT License
174 stars 33 forks source link

Cosmetic fix for Firefox is breaking grid?! #118

Closed APusch-Tenno closed 6 months ago

APusch-Tenno commented 6 months ago

hello,

I used the unchanged download for version 1.1.2 and replaced the specific files with those from the fix for Firefox, but now any grid is showing incorrectly:

grafik grafik

This also happens in Chrome. What am I missing here?

danheron commented 6 months ago

It looks like you are missing some styles. Did you replace the .scss files?

APusch-Tenno commented 6 months ago

Yes, I also replaced the styles. I checked the files many times.

At first I thought its something I changed in my project, but then I tested it with the unedited download and it still happened.

danheron commented 6 months ago

Is it possible your browser has cached an old version of the .css file? Maybe try clearing your browser history.

APusch-Tenno commented 6 months ago

I checked version 1.1.2 before applying the fix on it and it displayed fine (except the usual issue in Firefox of course). Cleared the cache, same result. If there was a cached version of that site, it would display as before.

Are you sure all changed files are uploaded to GitHub?

danheron commented 6 months ago

Yes, all changed files are uploaded to Github.

You'll have to use the browser dev tools to try and find out why it's not working. Have a look at the mud-cal-grid and mud-cal-grid-header classes.

APusch-Tenno commented 6 months ago

I don't know what went wrong there. When I did it a second time with the unchanged 1.1.2 the grid looked different (but still not correct, since it had no grid lines). Maybe while comparing the files with WinMerge something got messed up.

Then I downloaded all files from the fix again and applied them again to the unchanged 11.2 and it worked.

The only problem I have now is, that I added a work week/5 day week, which is now being shifted like someone took out the weekends from the grid, but I basically only copied the 7 day week and changed some values. This change worked fine before the fix.

I am hoping the person in the other issue about the work week will provide a pull request which will work with the Firefox fix.

Thanks for your time.

danheron commented 6 months ago

I'm glad you got it working.

The change to using a css grid was a big change so I'm not too surprised that it broke the changes you made. This is why the change is being released in a new major version number.