Sumitting Prework assignment!

[danhnn]

Here is my completed Pre-work assignment! Thank you!

/cc @coderschoolreview

[coderschoolreview]

Thank you for your Rails submission, harry-nguyen-88!

:grin: Everything looks good with the format of your submission. We'll be reviewing your submission soon!

[nvh0412]

Hi @harry-nguyen-88

Thanks for submitting early! Amazing Pre-work assignment.

For a quick review, your submission is amazing, your UI is a impressive view , your layout have been structured very rails style. Nice to see your validations in models as well (your comment model doesn't have validations :scream: ). I'm so excited when i saw your jbuilder file and json and html, you had returned both of them in create/update/destroy action. :+1: But you still didn't use json result in your views. It's ok.

Suggestions

• If you have free time, i think you should refactor your code in ArticleController file. You can reduce repetition of your code.
  • Some functions need to be moved into article.rb file. Eg increaseHitCount, getRecentArticle. Have you know about Fat model, Skinny Controller?. :).
  • In index action Order has been repeated multiple times, so if i use rails style:

@articles = Article.all
@articles = @articles.search(params[:search]) if params[:search]
@articles = @articles.searchByTag(params[:tag]) if params[:tag]
@articles = @articles.order("created_at DESC")

• You should use some build-in view helper of rails to make your data always is showed as you expected. In this line You can use truncate helper to limit your number words which has been showed in your view.
• You can create dump data for your project by using seed.rb file

There is no denial that your submission is one of best our submission, congratulation. :dancer: /cc @coderschoolreview /cc @harley

[danhnn]

Hi @nvh0412

Thank you so much for reviewing my test!

Actually I spent much time in layout design and mobile optimization so the blog had some issues for coding like you said such as "Fat model, Skinny Controller" rule, DRY, View helper ... and I highly appreciate your suggestions :+1:. Actually after submission, I had reviewed my code and seen some of those issues already but cannot submit the fix anymore :scream:. ha ha.

I think for the next project I will try to balance the layout design and code review so will be easy to fix bug and maintain the code base in the future. Once again, thank you so much :hand:

[danhnn]

Hi @nvh0412

Could you please let me know when we will have a Ruby's test result ? :smile: Cause next Tuesday (8-3) will be the first day of Ruby class then I think we should have a result soon (today is 6-3 already) so the one who pass the test can arrange their time to join. Thank you very much! :smiley:

[harley]

Hi @harry-nguyen-88 sorry it looks like our email may not have reached you. I've just tried again and am also reaching out directly on FB. See you in class tomorrow!

[danhnn]

Hi @harley , I have just received the confirm email :smile: I though I have failed that test already ha ha.Thank you so much!