search

danhper / atomic-chrome-atom

Edit Chrome textareas in Atom
https://goo.gl/haazl1
MIT License
93 stars 18 forks source link

Focus Atom application when text-synced from chrome browser #19

Closed t9md closed 7 years ago

t9md commented 7 years ago

This is we discussed in https://github.com/tuvistavie/atomic-chrome/issues/28

But it reveals it's achievable only by atomic-chrome-atom side.

And I could see slight activation time reduction from 40ms/avg to 30ms/avg by deferred require for ws-handler.

I can make it config option (e.g. automaticallyActivateAtomWindow ), but IMO this is all user's expectation so didn't do that.

How do you think?

danhper commented 7 years ago

Thanks for the PR, and sorry for the delay, I will take a look during the weekend!

t9md commented 7 years ago

I'm working for improving package activation time(faster package activation). And noticed atomic-chrome-atom always appear on the list of Timecop: View as slow package. Here is my workaround for not interfering startup of Atom.

https://github.com/t9md/atomic-chrome-atom/blob/experiment/lib/atomic-chrome.coffee

If you are OK for that I can send separate PR for that. Or hope you apply this change by yourself.

danhper commented 7 years ago

Very sorry for the delay, I completely forgot about this PR :sweat: Anyway, thank you very much!