search

danhper / fundle

A minimalist package manager for fish shell
MIT License
374 stars 22 forks source link

Provide path to plugin in repository #13

Closed Perlence closed 8 years ago

Perlence commented 8 years ago

This pull request is based upon issue #11. It adds optional flag for URL and an optional argument --path PATH that specifies root of the plugin in repository to be loaded by fundle.

The usage of fundle plugin is now:

fundle plugin NAME [[--url] URL] [--path PATH]
danhper commented 8 years ago

Great job, thank you very much! It looks very nice, I'll release a new version including this feature.

danhper commented 8 years ago

@Perlence I just updated the documentation and released v0.4.0 with your changes, thanks again!

Perlence commented 8 years ago

@tuvistavie You are welcome :+1:

Perlence commented 8 years ago

@tuvistavie Just to clarify, --url bit is not required, I did it for backward compatibility. Did you intend to drop this compatibility in future versions when you were writing docs?

danhper commented 8 years ago

@Perlence Yes, thanks I noticed it was not required but I think I will drop it in future versions, so I changed the docs to use only the usage with --url. I will probably add a deprecation notice for the second argument in the next release.