Closed enricobacis closed 8 years ago
Hi, and thank you for the PR.
I am fine with changing install -u
to update
, I agree it is
more explicit, and yes, explicit is better than implicit IMO.
However, I would rather keep self-update
as is, for the same reason
as above, it is more explicit.
Most package managers use update
to update the DB and upgrade
to actually upgrade the package, which does not make sense here
as we do not have a DB, so even if Vundle uses upgrade
,
I think self-update
is clearer.
Could you please update the PR with only the change from install -u
to update
,
and update the tests, as they are currently breaking?
Also, install -u
should only emit a deprecation warning for now, as
it could potentially break some scripts.
Thank you :smile:
I have updated the PR with the following:
self-update
-> upgrade
changeupdate
command that only adds __update
in the $sub_args
, this way we can check if the user used the -u
of --upgrade
option, notify the deprecation and add the __update
flag to trigger the updates.@enricobacis Great, thank you!
I would prefer to have the verbs to match the ones used by Vundle (I opened the issue #17), so I changed:
fundle install -u
->fundle update
fundle self-update
->fundle upgrade
This commit is just a draft of the changes, it should be refined for coding style.