danhper / fundle

A minimalist package manager for fish shell
MIT License
375 stars 22 forks source link

change verbs to match the ones of Vundle #18

Closed enricobacis closed 8 years ago

enricobacis commented 8 years ago

I would prefer to have the verbs to match the ones used by Vundle (I opened the issue #17), so I changed:

fundle install -u -> fundle update fundle self-update -> fundle upgrade

This commit is just a draft of the changes, it should be refined for coding style.

danhper commented 8 years ago

Hi, and thank you for the PR.

I am fine with changing install -u to update, I agree it is more explicit, and yes, explicit is better than implicit IMO.

However, I would rather keep self-update as is, for the same reason as above, it is more explicit. Most package managers use update to update the DB and upgrade to actually upgrade the package, which does not make sense here as we do not have a DB, so even if Vundle uses upgrade, I think self-update is clearer.

Could you please update the PR with only the change from install -u to update, and update the tests, as they are currently breaking? Also, install -u should only emit a deprecation warning for now, as it could potentially break some scripts.

Thank you :smile:

enricobacis commented 8 years ago

I have updated the PR with the following:

danhper commented 8 years ago

@enricobacis Great, thank you!