danhper / fundle

A minimalist package manager for fish shell
MIT License
375 stars 22 forks source link

Cannot `fundle update` #24

Closed hauleth closed 8 years ago

hauleth commented 8 years ago

Output message:

fatal: Not a git repository (or any of the parent directories): .git
fatal: Not a git repository (or any of the parent directories): .git
fatal: Not a git repository (or any of the parent directories): .git
Updating hauleth/agnoster
Updating fishery/rbenv
Updating fishery/z
danhper commented 8 years ago

Hi, thanks for reporting.

For some reason, the .git directory seems to be missing from some of your plugins. Just to be sure, could you paste the output of

find ~/.config/fish/fundle/ -maxdepth 3 -type d   

please?

hauleth commented 8 years ago
/Users/hauleth/.config/fish/fundle/
/Users/hauleth/.config/fish/fundle//fishery
/Users/hauleth/.config/fish/fundle//fishery/rbenv
/Users/hauleth/.config/fish/fundle//fishery/rbenv/.git
/Users/hauleth/.config/fish/fundle//fishery/rbenv/completions
/Users/hauleth/.config/fish/fundle//fishery/rbenv/conf.d
/Users/hauleth/.config/fish/fundle//fishery/rbenv/functions
/Users/hauleth/.config/fish/fundle//fishery/z
/Users/hauleth/.config/fish/fundle//fishery/z/.git
/Users/hauleth/.config/fish/fundle//fishery/z/conf.d
/Users/hauleth/.config/fish/fundle//fishery/z/functions
/Users/hauleth/.config/fish/fundle//fishery/z/man
/Users/hauleth/.config/fish/fundle//fishery/z/test
/Users/hauleth/.config/fish/fundle//hauleth
/Users/hauleth/.config/fish/fundle//hauleth/agnoster
/Users/hauleth/.config/fish/fundle//hauleth/agnoster/.git
/Users/hauleth/.config/fish/fundle//hauleth/agnoster/agnoster
/Users/hauleth/.config/fish/fundle//hauleth/agnoster/screenshots

It seems ok, it looks like fundle do not provide proper GIT_DIR when updating.

hauleth commented 8 years ago

I think that you should also provide GIT_WORK_TREE variable while updating.

danhper commented 8 years ago

Yeah, this seems to be fine.

I am setting git-dir through the --git-dir option, could it be that it gets overriden by an env variable?

I am passing the work-tree during the call to checkout, which should be enough. Any other place you think it should be present?

hauleth commented 8 years ago

Ok, I have found the issue. I have overrided git with hub which do not pass --git-dir command to the origin git. You should use command git instead of bare git to be sure that origin git was ran. I will fill issue against hub also.

danhper commented 8 years ago

@hauleth Thank you for investigating! I will change to command git to be safe, just a moment :smile:

danhper commented 8 years ago

I fixed it and updated to 0.5.2, could you run fundle self-update and tell me if it works please? :smile:

hauleth commented 8 years ago

You forgot to push tag ;)

danhper commented 8 years ago

Woops :sweat: Here you go! :tada:

hauleth commented 8 years ago

Works, thanks.

Wiadomość napisana przez Daniel Perez notifications@github.com w dniu 17.06.2016, o godz. 13:22:

Woops 😓 Here you go! 🎉

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/tuvistavie/fundle/issues/24#issuecomment-226745088, or mute the thread https://github.com/notifications/unsubscribe/AARzN505qYTdNyWLb6P3Rwm7iaV6gBz9ks5qMoNsgaJpZM4I4PJ0.