danhper / fundle

A minimalist package manager for fish shell
MIT License
375 stars 22 forks source link

Support fisherman-style conf.d and key_bindings.fish #30

Closed neersighted closed 7 years ago

neersighted commented 7 years ago

Support for conf.d in fisherman-style plugins, as well as key_binding.fish files. We save the fish_user_key_bindings function if defined, and then overwrite it with our own that sources all key_binding files. Then, we call the user's original function if it exists.

Closes #29

danhper commented 7 years ago

Hi, thank you very much! In what kind of situation is key_bindings.fish used/needed?

neersighted commented 7 years ago

key_bindings.fish is used by fisherman/oh-my-fish style plugins to hook into the new(ish) fish_user_keybindings function, where users are supposed to put their bind commands.

fisherman overwrites the file to add in the plugin-defined files, whereas oh-my-fish modifies the function to source plugin-defined files. I have taken the latter approach.

Some examples of plugins using this are:

neersighted commented 7 years ago

Closing real quick to re-run ci

danhper commented 7 years ago

I see, thanks for the explanation. Let's make this a new minor version then, thank you very much for the help.

jorgebucaran commented 5 years ago

Like to report that this information is now outdated, just in case someone stumbles upon it in the future.

Cheers!