danhper / fundle

A minimalist package manager for fish shell
MIT License
375 stars 22 forks source link

Warning about '' being invalid integer in test #32

Closed zimme closed 6 years ago

zimme commented 6 years ago

In __fundle_compare_versions there's a chance that $v1 or $v2 is empty which creates warnings with the -lt/-gt comparisons as an empty value isn't a valid integer.

I see that you check for the case when one is present and the other one isn't. However I don't know how to change the code so that it only does the -lt/-gt checks when both values are present.

zimme commented 6 years ago

I'm seeing this when running fundle self-update.

danhper commented 6 years ago

Thanks for reporting, this should now be fixed.