danhper / fundle

A minimalist package manager for fish shell
MIT License
375 stars 22 forks source link

feat: Add support for @<tag> in plugin name #54

Closed SirWrexes closed 2 years ago

SirWrexes commented 3 years ago

Choosing a specific release of a plugin should be done in a user friendly way. Therefore, it should be as simple as adding a tag at the end of the plugin name consisting of username/repository. This small modifications makes this possible using '@' as a delimiter.

Example: fundle plugin 'joseluisq/gitnow@2.7.0'

Not selecting a tag still acts the same as usual.

SirWrexes commented 3 years ago

I realise I should probably edit the README.md. :thinking: I'll do that.

SirWrexes commented 3 years ago

I have made the changes using the string split function, squashed the commits and pushed. Also I added a small note in the description of the --url option explaining it overrides tag selection via @ (since it manually sets the URL for the repo).

danhper commented 2 years ago

@SirWrexes Again, very sorry for not noticing this and thanks a lot!