search

danhper / opencov

Open source code coverage history webapp
http://demo.opencov.com
MIT License
317 stars 42 forks source link

commit_link in gitlab also with */commit/* #19

Open daqingshu opened 5 years ago

daqingshu commented 5 years ago

https://github.com/danhper/opencov/blob/cda5dcde9a4ef54c4d45aaefd124d0e5900ee284/web/views/common_view.ex#L41

example URL https://gitlab.com/gitlab-org/gitlab-ce/commit/4b76d631e44a339f5301ed151fd8ce6af1443aa8

danhper commented 5 years ago

Hi, thanks for reporting. Could you open a PR with the required changes please? I will be more than happy to merge.

daqingshu commented 5 years ago

Hi, thanks for reporting. Could you open a PR with the required changes please? I will be more than happy to merge.

I'm a newbie, what solution do you prefer to solve this problem?

bfontaine commented 4 years ago

@daqingshu I don’t know the codebase but I’d assume you can add a String.contains?(url, "gitlab.com") line like the one above.