search

danhper / plug-navigation-history

Elixir plug to keep navigation history
https://hex.pm/packages/navigation_history
MIT License
72 stars 15 forks source link

Add possibility to pass the session to last_path/3 and last_paths/2 #9

Closed EasterPeanut closed 3 years ago

EasterPeanut commented 3 years ago

Would like to propose the following change to the last_path(s) helpers.

Instead of just the conn, let these helpers also accept a map representing the session. This because when in using Phoenix LiveViews there is no conn available, but there is the session on mount. This can be helpful whenever one would like to redirect to the last non-LiveView path visited.

danhper commented 3 years ago

Hi! LiveView was not around yet when I first built this but this makes a lot of sense! Thanks a lot for the PR!

danhper commented 3 years ago

I just pushed a new version with your changes, thanks again!

EasterPeanut commented 3 years ago

I just pushed a new version with your changes, thanks again!

Cool, thank you as well :D