search

danhunsaker / angular-dynamic-forms

Build Forms in AngularJS From Nothing But JSON (please see Alternatives in the README)
MIT License
379 stars 140 forks source link

Add bower.json #23

Closed kynan closed 10 years ago

kynan commented 10 years ago

Allows installing the component via bower (once registered).

danhunsaker commented 10 years ago

Not familiar with bower configs yet. Can this be tested without merging?

kynan commented 10 years ago

Yep: bower install https://github.com/kynan/angular-dynamic-forms.git#bower

danhunsaker commented 10 years ago

OK, I'll merge this as soon as I'm able.

While I'm at it, though, are there other common package managers for JS libs?

kynan commented 10 years ago

bower is the de-facto standard. There used to be component.io, but that has been abandoned in favor of bower.

danhunsaker commented 10 years ago

K, cool. Should have it merged in the next hour or two. Really wish it was easier to do on mobile. :-)

What's the registration process?

kynan commented 10 years ago

Registration is really straightforward: bower register <name> <url>

danhunsaker commented 10 years ago

Oh, neat. Integrated into the CLI. Normally work with PHP, so I'm a bit behind the curve on these nifty kinds of things. Didn't get to merging this as quickly as I'd thought, but I'll comment again in here when I have. I'll also want to bump the version number when I do.

danhunsaker commented 10 years ago

Huh. There's another angular-dynamic-forms out there, and they beat me to bower. Well, I've been thinking of changing the name anyway, so maybe now's as good a time as any to start. This project is registered in bower as angular-dynforms. I'll be adding a note to that effect in the README, but I won't change the repo name for a while, until it's reasonable to expect that others have figured out the bower name, then I'll re-register it under the new name. (Unless others would recommend otherwise, of course.)

danhunsaker commented 10 years ago

Hrm. Should I add Angular as a dependency, or not?

kynan commented 10 years ago

There are different views on this: if you require a particular Angular version, probably yes. If not, I wouldn't because you might not want to use bower to manage Angular but instead e.g. load it from CDN. Others would argue that Angular is clearly a dependency and hence should be listed.

danhunsaker commented 10 years ago

Just the feedback I needed. I'll leave it out, since I don't depend on a specific version (everything I've tested from 1.0.8 up works fine), and tend to use a CDN for major libraries like Angular and jQuery myself.