search

danhunsaker / laravel-flysystem-others

Registers recognized third-party Flysystem adapters with Laravel automatically.
MIT License
22 stars 14 forks source link

FlysystemOtherManager function definition incompatible #13

Closed renardss-com closed 3 years ago

renardss-com commented 3 years ago

Hi all, There seems to be an issue when using laravel 8.61.0 and danhunsaker/laravel-file-system-others v1.4.0:

Declaration of Danhunsaker\Laravel\Flysystem\FlysystemOtherManager::resolve($name) should be compatible with Illuminate\Filesystem\FilesystemManager::resolve($name, $config = NULL)

FlysystemOtherManager.php row 397

re-define protected function resolve($name) to protected function resolve($name, $config = NULL)

and 399 $adapter = parent::resolve($name); to $adapter = parent::resolve($name, $config);

Fixed the issue for me. Cheers!

danhunsaker commented 3 years ago

See #11, #12