search

dani-garcia / rust_async_ftp

Fork of https://crates.io/crates/ftp with tokio async support
Apache License 2.0
21 stars 14 forks source link

Drop data stream before waiting close code #1

Closed dodomorandi closed 4 years ago

dodomorandi commented 4 years ago

I encountered an issue while listing files from an FTP server -- the close code is never send back just because the data connection is open. Just dropping data_stream solves the issue.

I took the freedom to bump the path version, if it is not a problem.

dani-garcia commented 4 years ago

Thanks, new version pushed to crates.io as well. If you find any more bugs you're welcome to submit issues or PRs as well. This is a port of https://crates.io/crates/ftp that I made in an afternoon because I needed some basic functionality (pretty much just login and retrieving an individual file), so it's not very well tested at the moment.

dodomorandi commented 4 years ago

Thank you! Don't worry -- if you took one afternoon to make it, I owe you an afternoon 😁. Unfortunately I discovered another thing for which I have to open an issue, I just did not have time today.

Just let me know how you want to handle the fact that a similar codebase exist for the ftp crate: there is a high probability that if an issue exists in async-ftp, it probably exists in ftp as well (not related with async things, obviously). If I send you some issues/PRs, would you rather to backport the patches without opening an issue, the PR and blablabla, or you would like me to help you syncing the issues of the two repos?