search

dani-garcia / rust_async_ftp

Fork of https://crates.io/crates/ftp with tokio async support
Apache License 2.0
21 stars 14 forks source link

Minor bug in FtpStream::get #6

Closed SamedhG closed 4 years ago

SamedhG commented 4 years ago

Line 298 in FtpStream in the get function is :

self.read_response(status::ABOUT_TO_SEND).await?;

but should be 

self.read_response_in(&[status::ABOUT_TO_SEND, status::ALREADY_OPEN]).await?;

(same as in the FtpStream::retr function)

Can this be fixed in the next release?

dani-garcia commented 4 years ago

Sounds reasonable, can you make a PR changing it?

SamedhG commented 4 years ago

Yeah will do.

SamedhG commented 4 years ago

Thanks! How often do updates get pushed to crates?

dani-garcia commented 4 years ago

Usually as soon as there are some changes, 4.0.3 is up now with your PR included.

SamedhG commented 4 years ago

Thank you so much! This was very helpful