search

dani-garcia / vaultwarden

Unofficial Bitwarden compatible server written in Rust, formerly known as bitwarden_rs
GNU Affero General Public License v3.0
36.72k stars 1.78k forks source link

Thumbnails not correctly displayed #1860

Closed andreastanner closed 3 years ago

andreastanner commented 3 years ago

With the newest Version of Bitwarden (Android App 2.11.0 (3598)) and also Self hosted Vaultwarden Version 2.20.4 , the thumbnails are not correctly displayed anymore. Some of them appear, others not. Bevor the this update in the last days, everything worked fine.

BlackDex commented 3 years ago

I think with thumbnails you mean favicons of the sites? In that case, please check the logs first, and if you do not see anything useful, try to enable the LOG_LEVEL=debug for a short time.

You may need to remove all the .miss files from your icon_cache folder to be sure it will trigger new icons to be downloaded. If that doesn't solve it, we need to have some logs and the Generated Support String from the /admin/diagnostics page.

andreastanner commented 3 years ago

I deleted all the .miss files but that didn't help. On thing I set up in the firewall is to only allow IP's from my country. In this case, when I make a new entry, the favicons can't be loaded of course. So if I wanted to make a new entry, I disabled IP Blocking for a short time and all favicons could be loaded correctly. But now, even if I deaktivate IP Blocking, now favicons can't be loaded nor the existing ones can be recognized. What's also funny is that some favicons in the bitwarden browser app are displayed and the same icons on android are not showed. And in the Firefox extension, again other favicons are showed, not the same one's like in the bitwarden browser app.

I also have a reverse proxy for the bitwarden port with an own domain but that was never a problem until now...

Do you have an idea what's wrong?

Here's the Support String (with IP Blocking):

Your environment (Generated via diagnostics page)

Config (Generated via diagnostics page)

Show Running Config **Environment settings which are overridden:** ADMIN_TOKEN ```json { "_duo_akey": null, "_enable_duo": false, "_enable_email_2fa": true, "_enable_smtp": true, "_enable_yubico": true, "_ip_header_enabled": true, "admin_token": "***", "allowed_iframe_ancestors": "", "attachments_folder": "data/attachments", "authenticator_disable_time_drift": false, "data_folder": "data", "database_max_conns": 10, "database_url": "****/**.*******", "db_connection_retries": 15, "disable_2fa_remember": false, "disable_admin_token": false, "disable_icon_download": false, "domain": "*****://*********.******************.***", "domain_origin": "*****://*********.******************.***", "domain_path": "", "domain_set": true, "duo_host": null, "duo_ikey": null, "duo_skey": null, "email_attempts_limit": 3, "email_expiration_time": 600, "email_token_size": 6, "enable_db_wal": true, "extended_logging": true, "helo_name": null, "hibp_api_key": null, "icon_blacklist_non_global_ips": true, "icon_blacklist_regex": null, "icon_cache_folder": "data/icon_cache", "icon_cache_negttl": 259200, "icon_cache_ttl": 2592000, "icon_download_timeout": 10, "invitation_org_name": "Vaultwarden", "invitations_allowed": true, "ip_header": "X-Real-IP", "job_poll_interval_ms": 30000, "log_file": null, "log_level": "Info", "log_timestamp_format": "%Y-%m-%d %H:%M:%S.%3f", "org_attachment_limit": null, "org_creation_users": "", "password_iterations": 100000, "reload_templates": false, "require_device_email": false, "rsa_key_filename": "data/rsa_key", "send_purge_schedule": "0 5 * * * *", "sends_allowed": true, "sends_folder": "data/sends", "show_password_hint": true, "signups_allowed": false, "signups_domains_whitelist": "", "signups_verify": false, "signups_verify_resend_limit": 6, "signups_verify_resend_time": 3600, "smtp_accept_invalid_certs": false, "smtp_accept_invalid_hostnames": false, "smtp_auth_mechanism": null, "smtp_debug": false, "smtp_explicit_tls": false, "smtp_from": "**********@*****.***", "smtp_from_name": "Mister X Bitwarden", "smtp_host": "****.*****.***", "smtp_password": "***", "smtp_port": 587, "smtp_ssl": true, "smtp_timeout": 15, "smtp_username": "**********@*****.***", "templates_folder": "data/templates", "trash_auto_delete_days": null, "trash_purge_schedule": "0 5 0 * * *", "use_syslog": false, "user_attachment_limit": null, "web_vault_enabled": true, "web_vault_folder": "web-vault/", "websocket_address": "0.0.0.0", "websocket_enabled": false, "websocket_port": 3012, "yubico_client_id": null, "yubico_secret_key": null, "yubico_server": null } ```
BlackDex commented 3 years ago

@andreastanner yea, it seems your docker container doesn't have internet access. It can resolve DNS but not access the internet.

andreastanner commented 3 years ago

oh that's no problem, see, I can disable IP Blocking and then bitwarden has internet access to download favicons (the only reason why bitwarden needs incoming traffic right?). If i then make new entries, the favicons can be loaded but not on the android app and the firefox extension, only on the bitwarden broswer web app... And this is the case since the new update, before everything worked fine ;).

Your environment (Generated via diagnostics page)

Config (Generated via diagnostics page)

Show Running Config **Environment settings which are overridden:** ADMIN_TOKEN ```json { "_duo_akey": null, "_enable_duo": false, "_enable_email_2fa": true, "_enable_smtp": true, "_enable_yubico": true, "_ip_header_enabled": true, "admin_token": "***", "allowed_iframe_ancestors": "", "attachments_folder": "data/attachments", "authenticator_disable_time_drift": false, "data_folder": "data", "database_max_conns": 10, "database_url": "****/**.*******", "db_connection_retries": 15, "disable_2fa_remember": false, "disable_admin_token": false, "disable_icon_download": false, "domain": "*****://*********.******************.***", "domain_origin": "*****://*********.******************.***", "domain_path": "", "domain_set": true, "duo_host": null, "duo_ikey": null, "duo_skey": null, "email_attempts_limit": 3, "email_expiration_time": 600, "email_token_size": 6, "enable_db_wal": true, "extended_logging": true, "helo_name": null, "hibp_api_key": null, "icon_blacklist_non_global_ips": true, "icon_blacklist_regex": null, "icon_cache_folder": "data/icon_cache", "icon_cache_negttl": 259200, "icon_cache_ttl": 2592000, "icon_download_timeout": 10, "invitation_org_name": "Vaultwarden", "invitations_allowed": true, "ip_header": "X-Real-IP", "job_poll_interval_ms": 30000, "log_file": null, "log_level": "Info", "log_timestamp_format": "%Y-%m-%d %H:%M:%S.%3f", "org_attachment_limit": null, "org_creation_users": "", "password_iterations": 100000, "reload_templates": false, "require_device_email": false, "rsa_key_filename": "data/rsa_key", "send_purge_schedule": "0 5 * * * *", "sends_allowed": true, "sends_folder": "data/sends", "show_password_hint": true, "signups_allowed": false, "signups_domains_whitelist": "", "signups_verify": false, "signups_verify_resend_limit": 6, "signups_verify_resend_time": 3600, "smtp_accept_invalid_certs": false, "smtp_accept_invalid_hostnames": false, "smtp_auth_mechanism": null, "smtp_debug": false, "smtp_explicit_tls": false, "smtp_from": "**********@*****.***", "smtp_from_name": "Mister X Bitwarden", "smtp_host": "****.*****.***", "smtp_password": "***", "smtp_port": 587, "smtp_ssl": true, "smtp_timeout": 15, "smtp_username": "**********@*****.***", "templates_folder": "data/templates", "trash_auto_delete_days": null, "trash_purge_schedule": "0 5 0 * * *", "use_syslog": false, "user_attachment_limit": null, "web_vault_enabled": true, "web_vault_folder": "web-vault/", "websocket_address": "0.0.0.0", "websocket_enabled": false, "websocket_port": 3012, "yubico_client_id": null, "yubico_secret_key": null, "yubico_server": null } ```
BlackDex commented 3 years ago

Well, it all seems to work for me on both Firefox and Android. Please check the logs of your reverse proxy and Vaultwarden to see if there is even an attempt to download them. For your Android App, I also suggest trying to force stop the app, clear the cache and start it again to see if that fixes the issue.