1.23.0 Release - Web build 2.23.0c Stray Organization items

[cksapp]

Latest Web build 2.23.0c contains stray fields when creating new Organization

When creating a new organization, New Organization page has additional option for "This account is owned by a business." When selected multiple form fields come up which were not properly removed during web build process, these appear to be the :

1. Business Name
2. Additional Storage (GB)
3. Country and Zip / Postal Code

When "This account is owned by a business" is deselected, Business Name field is removed but other form fields remain and prevent creation of Organization, requires page refresh or navigating to another Setting and back.

Deployment environment (Generated via diagnostics page)

• Vaultwarden version: v1.23.0
• Web-vault version: v2.23.0c
• Running within Docker: true (Base: Debian)
• Environment settings overridden: true
• Uses a reverse proxy: true
• IP Header check: true (X-Real-IP)
• Internet access: true
• Internet access via a proxy: false
• DNS Check: true
• Time Check: true
• Domain Configuration Check: true
• HTTPS Check: true
• Database type: SQLite
• Database version: 3.35.4
• Clients used:
• Reverse proxy and version:
• Other relevant information:

Config (Generated via diagnostics page)

Show Running Config

**Environment settings which are overridden:** DOMAIN, TRASH_AUTO_DELETE_DAYS, SIGNUPS_ALLOWED, SIGNUPS_VERIFY, ORG_CREATION_USERS, SHOW_PASSWORD_HINT, ADMIN_TOKEN, INVITATION_ORG_NAME, SMTP_HOST, SMTP_EXPLICIT_TLS, SMTP_PORT, SMTP_FROM, SMTP_FROM_NAME, SMTP_USERNAME, SMTP_PASSWORD ```json { "_duo_akey": null, "_enable_duo": false, "_enable_email_2fa": true, "_enable_smtp": true, "_enable_yubico": true, "_ip_header_enabled": true, "admin_token": "***", "allowed_iframe_ancestors": "", "attachments_folder": "data/attachments", "authenticator_disable_time_drift": false, "data_folder": "data", "database_max_conns": 10, "database_url": "****/**.*******", "db_connection_retries": 15, "disable_2fa_remember": false, "disable_admin_token": false, "disable_icon_download": false, "domain": "*****://**-**-****.********.***", "domain_origin": "*****://**-**-****.********.***", "domain_path": "", "domain_set": true, "duo_host": null, "duo_ikey": null, "duo_skey": null, "email_attempts_limit": 3, "email_expiration_time": 600, "email_token_size": 6, "emergency_access_allowed": true, "emergency_notification_reminder_schedule": "0 5 * * * *", "emergency_request_timeout_schedule": "0 5 * * * *", "enable_db_wal": true, "extended_logging": true, "helo_name": null, "hibp_api_key": null, "icon_blacklist_non_global_ips": true, "icon_blacklist_regex": null, "icon_cache_folder": "data/icon_cache", "icon_cache_negttl": 259200, "icon_cache_ttl": 2592000, "icon_download_timeout": 10, "invitation_org_name": "2902Home", "invitations_allowed": true, "ip_header": "X-Real-IP", "job_poll_interval_ms": 30000, "log_file": "/data/vaultwarden.log", "log_level": "warn", "log_timestamp_format": "%Y-%m-%d %H:%M:%S.%3f", "org_attachment_limit": null, "org_creation_users": "*****@********.***", "password_iterations": 100000, "reload_templates": false, "require_device_email": false, "rsa_key_filename": "data/rsa_key", "send_purge_schedule": "0 5 * * * *", "sends_allowed": true, "sends_folder": "data/sends", "show_password_hint": false, "signups_allowed": false, "signups_domains_whitelist": "********.***", "signups_verify": true, "signups_verify_resend_limit": 6, "signups_verify_resend_time": 3600, "smtp_accept_invalid_certs": false, "smtp_accept_invalid_hostnames": false, "smtp_auth_mechanism": null, "smtp_debug": false, "smtp_explicit_tls": true, "smtp_from": "**-*****@********.***", "smtp_from_name": "Bitwarden", "smtp_host": "****.*****.***", "smtp_password": "***", "smtp_port": 465, "smtp_ssl": true, "smtp_timeout": 15, "smtp_username": "****@********.***", "templates_folder": "data/templates", "trash_auto_delete_days": 180, "trash_purge_schedule": "0 5 0 * * *", "use_syslog": false, "user_attachment_limit": null, "web_vault_enabled": true, "web_vault_folder": "web-vault/", "websocket_address": "0.0.0.0", "websocket_enabled": true, "websocket_port": 3012, "yubico_client_id": null, "yubico_secret_key": null, "yubico_server": null } ```

• vaultwarden version: Docker 1.23.0

• Install method:

• Clients used: Webclient

• Reverse proxy and version: Caddy2

• MySQL/MariaDB or PostgreSQL version: SQlite

Steps to reproduce

1. Under Settings > Organizations select button to create + New Organization This account is owned by a business field is available, but not selected.

2. This account is owned by a business field is selected, additional form fields are now available.

3. This account is owned by a business field is unselected, but additional form fields are not removed.

4. If This account is owned by a business field is selected, then any data input into the form fields will give an error when creating the Org. If selecting This account is owned by a business. field and then deselecting box form fields are left, requires at least Country filled to continue and produces the same error upon attempted Org creation.

5. Error message does not show up after failure and waiting, requires some type of page update, such as refresh (F5), or selecting another setting or clicking back to the Organizations tab.

Expected behavior

Disable This account is owned by a business. option when building web vault from upstream, similar to previous web build 2.21.1 to prevent additional form fields from being rendered, or allow for Organizations to be created with Business data (though I am not sure how applicable this would be)

[jjlin]

PR dani-garcia/bw_web_builds#54 is already open for this.

[cksapp]

Did not see any open issues, or PR associated with this. Did not check the bw_web_builds repo, only the main Vaulwarden code repo. Glad to see someone else was already aware of this, and there is already a PR open to fix. Awesome, thanks!