Check regex blacklist in internal icon resolver

dani-garcia / vaultwarden

Unofficial Bitwarden compatible server written in Rust, formerly known as bitwarden_rs

GNU Affero General Public License v3.0

34.78k stars 1.69k forks source link

Check regex blacklist in internal icon resolver #4539

Closed 1fexd closed 2 months ago

BlackDex commented 2 months ago

This is already done here https://github.com/dani-garcia/vaultwarden/blob/main/src/util.rs#L864...L872

So there should be no need for this PR. Are you experiencing some issues?

1fexd commented 2 months ago

Oh, you are absolutely right, it never actually looks up the url - my bad.

Do you think it would make sense to exclude .onion/.i2p from icon fetching by default (and allow enabling it via an environment variable)? Also, I feel like logging each icon request with the domain on the info log level is a little invasive