Switch to Github Actions cache

dani-garcia / vaultwarden

Unofficial Bitwarden compatible server written in Rust, formerly known as bitwarden_rs

GNU Affero General Public License v3.0

37.35k stars 1.82k forks source link

Switch to Github Actions cache #4585

Closed dfunkt closed 4 months ago

dfunkt commented 4 months ago

remove releasecache-cleanup.yml, GHA cache auto removes oldest cache files after 10GB usage or files not being accessed for more than 7 days
remove unnecessary step in release.yml, GHA cache doesn't require GHCR login

More info: https://github.com/moby/buildkit?tab=readme-ov-file#github-actions-cache-experimental

BlackDex commented 4 months ago

First, thanks for the PR.

The reason we do not use GHA cache is because our builds take-up a lot of storage. In the end more then the permitted 10GB. That is why we use the GitHub Container Registry.

Before we used GHA Cache, but that in the end was almost never fully used because cache invalidation. If you think this is not the case then please elaborate on it, else I'm inclined to closing this.

dfunkt commented 4 months ago

Fair enough, sounds like a reasonable explanation. This was one of the things I was using in my builds since I didn't want to bother with manually cleaning the caches and it seemed to work well enough.