search

dani-garcia / vaultwarden

Unofficial Bitwarden compatible server written in Rust, formerly known as bitwarden_rs
GNU Affero General Public License v3.0
34.71k stars 1.69k forks source link

Cannot Login Using Bitwarden Mobile Native #4656

Closed privacytime101 closed 1 week ago

privacytime101 commented 2 weeks ago

Subject of the issue

Can’t log into the new public beta of the Bitwarden Mobile native apps. Using the official bitwarden.com instance, the login works. On a Vaultwarden instance, it gives an “an error occurred” alert on all platforms that were tested. v2024.6.1 tested on iOS 18 Developer Beta 1, iOS 17.5.1 Stable, Android stable (unknown version, community-reported).

Deployment environment

Steps to reproduce

Open the new Bitwarden native app, set your self-hosted instance, try to log in.

Expected behaviour

The login proceeds as normal (as seen while using the official bitwarden.com instance).

Actual behaviour

“an error occurred” message shows up. The error is not caused by the credentials being incorrect, nor by MFA being enabled.

BlackDex commented 2 weeks ago

Already resolved via #4386 , which just needs some extra testing.

Polarzincomfrio commented 2 weeks ago

Already resolved via #4386 , which just needs some extra testing.

Any eta on when it'll be merged, or are there many bugs w/ it?

BlackDex commented 2 weeks ago

No eta, timelines or release schedules.

And to see if there are many bugs in it we need to review it first 😉

tessus commented 2 weeks ago

@BlackDex I believe I am still a bit confused when it comes to releases and the master branch (testing). It seems to me that testing is used by people, because releases often do not work with the recent clients. Thus testing (master branch and testing containers) is not really a testing branch but a different prod branch.

Otherwise it would make sense to merge the mentioned PR and let people test. It seems to me that PRs are only merged to master when they are prod ready. Thus it would make sense to create a testing branch from which real testing containers and maybe pre-releases are published.

I am sorry to post in this issue, but I think my comment has merrit, especially when it comes to the camelcase PR.

Maybe you can clarify the release/testing/master meanings, because I seriously have problems to understand them in this project.

BlackDex commented 2 weeks ago

Testing is based upon the code located in master. Any PR or push to master will trigger a build and will push new containers tagged with testing.

If we create a tag, which we set to a n.n.n format that will trigger a new stable and versioned latest tagged release.

When we will create a tag is not defined anywhere. It's more a mixture of, should we wait for pr x or y to be finished, or are the merged changes since the previous tagged release long enough in testing for people to tested it and report issues. Or are there any open issues which we want to have addressed before releasing a new tagged version.

tessus commented 2 weeks ago

That all I understand and knew already. My point is that testing is not really testing, because you only push prod ready PRs to master, which is the branch used for creating the testing containers. So for me testing is a branch or a container to test code that is not prod ready yet. But this does not exist in this project, otherwise you would have merged several PRs already which you would like people to test. In this project testing is a container that is the latest prod, but without a specific release tag. That's all. This is not testing in the sense of testing. ;-) I really do not want to hijack this issue, we can or should move this specific conversation to a discussion.

BlackDex commented 2 weeks ago

So, start s discussion then 😉

seraphblade2010 commented 2 weeks ago

@BlackDex I will hijack this Issue for one simple question: When are new vaultwarden web releases coming to this project? Vaultwarden itself is on 2024.6 and this project sits at 2024.1.2.

Maybe im just confused but maybe you can help me understand when new web versions are coming ^^

BlackDex commented 2 weeks ago

If you use testing you would have v2024.5.1 right now. We do not have eta's, schedules for our stable/versioned releases.

Lovest20018 commented 1 week ago

Do you need to log in to the new beta app for Android by 2024.06? Updating to testing 2024.5.1 still prompts an error.

dfunkt commented 1 week ago

That's the web-client version, not relevant to the mobile apps. The new mobile apps are not compatible yet with any vaultwarden version (stable or testing). Only after https://github.com/dani-garcia/vaultwarden/pull/4386 gets merged will the testing images be compatible with the new apps. (+ maybe a new stable version could be released for compatibility reasons, who knows)