Fix some nightly build errors

dani-garcia / vaultwarden

Unofficial Bitwarden compatible server written in Rust, formerly known as bitwarden_rs

GNU Affero General Public License v3.0

34.71k stars 1.69k forks source link

Fix some nightly build errors #4657

Closed dani-garcia closed 2 weeks ago

dani-garcia commented 2 weeks ago

I was building vaultwarden with the latest rust nightly and was met with a couple of build errors/warnings.

Some unknown cfg warnings about the cfg's that we define based on features, which I disabled in the build.rs file
Some type inference errors, where a couple of functions were inferring the ! type instead of (). I'm not sure if this is a transient error or will become a hard error in a future stable release, but it was easy enough to solve.

This was using nightly 2024-06-18

BlackDex commented 2 weeks ago

It will become a hard error stated by the warning: warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!

Probably only when we switch to the 2024 edition.

BlackDex commented 2 weeks ago

@dani-garcia i just noticed that a few are missed, because you probably only tested the sqlite feature ;).

dani-garcia commented 2 weeks ago

Missed those hah, should be fixed in https://github.com/dani-garcia/vaultwarden/pull/4661