dani-garcia / vaultwarden

Unofficial Bitwarden compatible server written in Rust, formerly known as bitwarden_rs
GNU Affero General Public License v3.0
34.71k stars 1.69k forks source link

Extension Update Item Collections returns Error #4681

Open TheMardy opened 1 week ago

TheMardy commented 1 week ago

Extension Change Collection not working

When trying to add/remove an item to an organization collection in the Extension, it errors.

Deployment environment

Your environment (Generated via diagnostics page)

Steps to reproduce

Open Extension (Chrome / Firefox, 2024.6.2) -> Item -> Edit -> Collections -> Check a different collection -> Save

Expected behaviour

Save the item and add it to the collection

Actual behaviour

It Errors.

Troubleshooting data

The extension uses a different request than the app/web interface:

Mobile:

[2024-06-20 13:14:53.052][request][INFO] PUT /api/ciphers/0d673397-9bca-4bd4-b5ad-a51f8456813d
[2024-06-20 13:14:53.059][response][INFO] (put_cipher) PUT /api/ciphers/<uuid> => 200 OK
[2024-06-20 13:14:53.083][request][INFO] GET /api/ciphers/0d673397-9bca-4bd4-b5ad-a51f8456813d/details
[2024-06-20 13:14:53.084][response][INFO] (get_cipher_details) GET /api/ciphers/<uuid>/details => 200 OK
[2024-06-20 13:14:53.128][request][INFO] GET /api/ciphers/0d673397-9bca-4bd4-b5ad-a51f8456813d/details
[2024-06-20 13:14:53.129][response][INFO] (get_cipher_details) GET /api/ciphers/<uuid>/details => 200 OK
[2024-06-20 13:14:53.181][request][INFO] GET /api/ciphers/0d673397-9bca-4bd4-b5ad-a51f8456813d/details
[2024-06-20 13:14:53.182][response][INFO] (get_cipher_details) GET /api/ciphers/<uuid>/details => 200 OK

[2024-06-20 13:15:12.043][request][INFO] PUT /api/ciphers/0d673397-9bca-4bd4-b5ad-a51f8456813d/collections
[2024-06-20 13:15:12.049][response][INFO] (put_collections_update) PUT /api/ciphers/<uuid>/collections => 200 OK
[2024-06-20 13:15:12.067][request][INFO] GET /api/ciphers/0d673397-9bca-4bd4-b5ad-a51f8456813d/details
[2024-06-20 13:15:12.068][response][INFO] (get_cipher_details) GET /api/ciphers/<uuid>/details => 200 OK
[2024-06-20 13:15:12.084][request][INFO] GET /api/ciphers/0d673397-9bca-4bd4-b5ad-a51f8456813d/details
[2024-06-20 13:15:12.084][request][INFO] GET /api/ciphers/0d673397-9bca-4bd4-b5ad-a51f8456813d/details
[2024-06-20 13:15:12.085][response][INFO] (get_cipher_details) GET /api/ciphers/<uuid>/details => 200 OK
[2024-06-20 13:15:12.086][response][INFO] (get_cipher_details) GET /api/ciphers/<uuid>/details => 200 OK
[2024-06-20 13:15:12.098][request][INFO] GET /api/ciphers/0d673397-9bca-4bd4-b5ad-a51f8456813d/details
[2024-06-20 13:15:12.099][response][INFO] (get_cipher_details) GET /api/ciphers/<uuid>/details => 200 OK
[2024-06-20 13:15:12.128][request][INFO] GET /api/ciphers/0d673397-9bca-4bd4-b5ad-a51f8456813d/details
[2024-06-20 13:15:12.129][response][INFO] (get_cipher_details) GET /api/ciphers/<uuid>/details => 200 OK

Extension:

[2024-06-20 13:15:59.816][request][INFO] PUT /api/ciphers/0d673397-9bca-4bd4-b5ad-a51f8456813d/collections_v2
[2024-06-20 13:15:59.816][response][INFO] 404 Not Found
BlackDex commented 1 week ago

We are currently missing that endpoint and it is also needed for newer web-vaults.