search

dani-garcia / vaultwarden

Unofficial Bitwarden compatible server written in Rust, formerly known as bitwarden_rs
GNU Affero General Public License v3.0
39.25k stars 1.9k forks source link

don't infer manage permission for groups #5190

Closed stefan0xC closed 1 week ago

stefan0xC commented 1 week ago

the web-vault v2024.6.2 currently cannot deal with manage permission so instead of relying on the org user type this should just default to false (until we implement this correctly).

should fix #5160

BlackDex commented 1 week ago

Is this only for groups? Or also collections? Because it works there if I'm correct. I have tested it with groups and collections so i find it strange this now needs to be reverted.

Ill have to check again a bit better. But if this fixes it.

stefan0xC commented 1 week ago

This would be for giving groups edit or view access to collections. I don't think this currently needs to have the manage permission set to true but I might be wrong.

BlackDex commented 1 week ago

I think the problem was with managers not able to handle stuff. So maybe, since we have owners and admins can manage all, would make it to only need to be checked for managers if they need access?

BlackDex commented 1 week ago

Ok, did a quick check, looks like this should work. It should only be done for versions after this specific web-vault it looks like. Ill wait to see what you think @stefan0xC

BlackDex commented 1 week ago

Ok. Did some more checking. And i think this should be ok to fix the mentioned issue. The original code is needed for 2024.10.5 as far as i have checked. But we are not there yet.