search

dani-garcia / vaultwarden

Unofficial Bitwarden compatible server written in Rust, formerly known as bitwarden_rs
GNU Affero General Public License v3.0
34.88k stars 1.7k forks source link

Icon extraction fails #565

Closed quthla closed 4 years ago

quthla commented 4 years ago

For saturn.de and bwin.com it will just create the miss file

mprasil commented 4 years ago

What version are you using?

quthla commented 4 years ago

Latest docker image. Were you unable to reproduce the issue?

mprasil commented 4 years ago

I think I was able to reproduce that with saturn.de, but bwin.com works fine for me. I'm not sure why saturn.de fails though, I can see this in logs:

Download failed for https://www.saturn.de/favicon.ico

But when I try to poke the same URL with curl, it works fine.

BlackDex commented 4 years ago

I have identified the bug this afternoon. It has to do with cookies, and rather the lack off but still sending the header. This breaks the saturn.de website. Trying to think of a good way to fix this.

mprasil commented 4 years ago

This was fixed in PR #644