search

dani-garcia / vaultwarden

Unofficial Bitwarden compatible server written in Rust, formerly known as bitwarden_rs
GNU Affero General Public License v3.0
36.78k stars 1.79k forks source link

Allow configuration of invitation org name when inviting users #825

Closed aroberts closed 4 years ago

aroberts commented 4 years ago

Subject of the issue

Inviting users via email results in a reference to a "bitwarden_rs" organization. This is turning out to be confusing to my users - it would be great if I could configure that string to be something else.

It looks like the string is hardcoded at src/api/admin.rs:164:

        let org_name = "bitwarden_rs";
        mail::send_invite(&user.email, &user.uuid, None, None, &org_name, None)

I think just being able to set this string via environment variables would solve my problem.

Your environment

dani-garcia commented 4 years ago

Sounds reasonable to me. Should we use the already existing SMTP_FROM_NAME as it serves a similar purpose? Or create a separate option?

aroberts commented 4 years ago

I'd vote for a separate var, but it would be great to default the new var's value to SMTP_FROM_NAME if left blank/unset

dani-garcia commented 4 years ago

Fixed, decided on creating a separate independent option to avoid making the configuration logic more complex than needed.