Enable client-side icon cache (HTTP Header)

dani-garcia / vaultwarden

Unofficial Bitwarden compatible server written in Rust, formerly known as bitwarden_rs

GNU Affero General Public License v3.0

36.3k stars 1.76k forks source link

Enable client-side icon cache (HTTP Header) #835

Closed PrivatePuffin closed 4 years ago

PrivatePuffin commented 4 years ago

Subject of the issue

Currently Icons are not cached client side, it would be nice if this gets made possible.

Expected behaviour

Icons are not a big risk being cached client side, expected would be that icons are client-cached by default or at least client-side icon caching is enabled using the web headers.

Actual behaviour

No icons are cached because the following header is set on the icons: cache-control: no-cache, no-store, max-age=0

dani-garcia commented 4 years ago

Oh this makes perfect sense! Implemented in https://github.com/dani-garcia/bitwarden_rs/commit/ebb36235a70a2c539a7656454de3478ae776aa22 thanks!

PrivatePuffin commented 4 years ago

Thats... fast! Thanks!