dani-garcia / vaultwarden

Unofficial Bitwarden compatible server written in Rust, formerly known as bitwarden_rs
GNU Affero General Public License v3.0
36.78k stars 1.79k forks source link

Can't save data if server is down #869

Closed uchagani closed 4 years ago

uchagani commented 4 years ago

Subject of the issue

This may not be an issue for bitwarden_rs but for the official browser extension but I figured I'd post it here first.

If the server is down, the browser extension can't add/save any new entries. While this makes sense overall I believe it should at least save to the local DB and then sync whenever the next sync happens (and when the server is available).

Your environment

Steps to reproduce

  1. Stop bitwarden_rs
  2. Create new credentials using a browser extension

Expected behaviour

New credentials are stored in the local db

Actual behaviour

New credentials fail to save

mqus commented 4 years ago

See https://community.bitwarden.com/t/offline-management-of-writeable-vault-items/107 for reference.

I don’t want to make simple what is really complex, but I think that to achieve offline modification is mandatory to add to bitwarden the ability to resolve conflicts between items. No?

Yes, which can be very complex. This is why this feature doesn’t exist today.

uchagani commented 4 years ago

Ok good so I'm not the only one with this issue. Seems like an important feature to have. Servers experience downtime. It's something applications should take into consideration. Hopefully Bitwarden arrives at the same conclusion.

Since this seems like core bitwarden functionality, should I go ahead and close this? Or is this something bitwarden_rs can implement?

On Thu, Feb 20, 2020 at 1:34 AM mqus notifications@github.com wrote:

See https://community.bitwarden.com/t/offline-management-of-writeable-vault-items/107 for reference.

I don’t want to make simple what is really complex, but I think that to achieve offline modification is mandatory to add to bitwarden the ability to resolve conflicts between items. No?

Yes, which can be very complex. This is why this feature doesn’t exist today.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/dani-garcia/bitwarden_rs/issues/869?email_source=notifications&email_token=AAIBHEFQCQOFDWB6CMTYDB3RDYP6HA5CNFSM4KYF3KY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMK5LYY#issuecomment-588633571, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIBHEBOP5V4JDAITSWVJHLRDYP6HANCNFSM4KYF3KYQ .

mprasil commented 4 years ago

Or is this something bitwarden_rs can implement?

Because the issue is with server being down, I don't think there's anything we could do server side. This would all have to be client side implementation upstream.