danialfarid / ng-file-upload

Lightweight Angular directive to upload files with optional FileAPI shim for cross browser support
MIT License
7.87k stars 1.6k forks source link

Additional IE11 select upload fix #1959

Open wsy89 opened 7 years ago

wsy89 commented 7 years ago

ngf-select is triggering file change twice in IE11 and this is making my model null. I know there was fix done in previous version by checking if the fileList is null in changeFn function but in my case, the list is not null but it was empty. This result in nullifying my file object.

Celadora commented 7 years ago

Just a heads up, this is still occurring in Chrome Version 59.0.3071.115 (Official Build) (64-bit), even with this patch applied.

Here is one example with the bug emphasized with an alert box: http://jsfiddle.net/2vq88rfs/1431/

To reproduce: select a file, open it, select a file a second time.

Note that the alert prompt will be displayed before the open file prompt (which will still open over the alert).

wsy89 commented 7 years ago

It looks like that will also go away once this patch is applied. I am still waiting for the owner of this library to accept the pull request.