danialfarid / ng-file-upload

Lightweight Angular directive to upload files with optional FileAPI shim for cross browser support
MIT License
7.87k stars 1.59k forks source link

Dragging non-files over the ngf-drop should not turn on valid dragover class #2007

Open fracz opened 7 years ago

fracz commented 7 years ago

If you drag a non-file over the ngf-drop, it should not turn on valid dragover class. IMO, it should set the rejection CSS class or does not react to such drag at all.

Here is what I mean (Chrome):

dragging-non-files

eddieconk commented 6 years ago

Agreed, this also causes issues with dragging and dropping text within an input element. By not catching this case, dragging and dropping text is disabled.