search

danialfarid / ng-file-upload

Lightweight Angular directive to upload files with optional FileAPI shim for cross browser support
MIT License
7.87k stars 1.6k forks source link

Catching the upload.dataUrl being rejected #2020

Closed reesemartin closed 1 year ago

reesemartin commented 6 years ago

Prevents the Angular 1.6 error log about "Possibly unhandled rejection" when promises aren't caught

fixes #2019

leolux commented 6 years ago

Over a month later now, could someone merge that please?

kennardconsulting commented 6 years ago

+1

kennardconsulting commented 6 years ago

Please?

wiktorsikora commented 6 years ago

+1

rbaras commented 6 years ago

+1

fuse12345 commented 6 years ago

+1

johnymotorhead commented 6 years ago

+1

gasfab999 commented 6 years ago

+1

phazei commented 6 years ago

not sure if this'll ever get merged, @danialfarid hasn't touched git hub since April 2017 :/

arunragha89 commented 5 years ago

The fix provided does not work with the latest ng-file-upload. I still get "Possibly unhandled rejection: " in console.

reesemartin commented 1 year ago

Merged separately but left open for 4 years. Necro closing this so it's not in my pull request list anymore lol