Fix broken / hijacked faker.js dependency 🐛 - Githubissues

danibram / mocker-data-generator

A simplified way to generate masive mock data based on a schema, you can use the awesome fake/random data generators like (FakerJs, ChanceJs, CasualJs and RandExpJs)

https://danibram.github.io/mocker-data-generator/

MIT License

426 stars 45 forks source link

Fix broken / hijacked faker.js dependency 🐛 #119

Closed dimorphic closed 1 year ago

dimorphic commented 2 years ago

Issues solved in this PR:

[x] [deps] Lock faker-js version to a previousnot hijacked version (repo is dead: https://github.com/marak/Faker.js/)
[x] [dist] Commit build dir so this can be installed from Github / locally and use the build files

Later to do:

[ ] Replace faker with community stable version: https://github.com/faker-js/faker instead of locked pre-hijack ?
[ ] Remove build dir once merged back into main package and republished to npm as stable?

@danibram Thanks for the package! 👋

ghost commented 2 years ago

CodeSee Review Map:

Review in an interactive map

View more CodeSee Maps

Legend

CodeSee Map Legend

danibram commented 1 year ago

Hi, I released a new version removing the generators from the package, so this is no longer needed ( I hope =) ). Thanks for your contribution anyway

dimorphic commented 1 year ago

@danibram 👍🎩