search

danicampora / micropython

The Micro Python project
MIT License
1 stars 1 forks source link

Use common code from the stmhal port (buffhelper, readline, etc.) #2

Closed danicampora closed 9 years ago

dpgeorge commented 9 years ago

Any board-specific functions should be in the cc3200_hal file.

danicampora commented 9 years ago

In buffhelper I haven't changed anything, so I'll go back to using the stmhal one. Regarding pyexec, I see that now the "USB" specific code has been replaced for "mphal", which makes it possible to use in my port without trouble.

dpgeorge commented 9 years ago

I see you made a "stdout_tx_char_rep" function for readline. We could incorporate this into stmhal, but I don't like how it allocates RAM to do the repeated send.

danicampora commented 9 years ago

Ok I see. It was mostly a hack to get it working quickly. How do you suggest to improve it?

dpgeorge commented 9 years ago

Did you find that you needed this repeat function? Why not leave it as a loop calling tx? A proper fix would be to use VT100 commands to do large erases on the screen.

danicampora commented 9 years ago

Wihout the repeat function it works, but the line flickers when pressing the up/down keys, because erasing the line character by character takes too much time over WiFi. Ok, lets look into the VT100 commands, perhaps that's the best solution.

BTW. I am almost done with pyexe and bufhelper, just waiting for the build...

danicampora commented 9 years ago

Done. Did some cleanup as well. I am onto the VT100 commands now.

danicampora commented 9 years ago

@dpgeorge with the last commit I think this ticket could be closed.

dpgeorge commented 9 years ago

Yes!