search

daniel-ac-martin / NotGovUK

An implementation of the GOV.UK Design System in React that provides support for writing internal applications in addition to public ones.
https://not-gov.uk/
MIT License
27 stars 8 forks source link

Update to the latest React (18) dependancy #1026

Closed ray-marr-ho closed 3 days ago

ray-marr-ho commented 1 month ago

Are there any plans to update to React 18? I am working on some projects using React 18 where we're unable to use the library without --legacy-peer-deps due to React version

daniel-ac-martin commented 3 weeks ago

@ray-marr-ho: Yes, this is planned. I think all it needs are updates to the types to make children explicit.

PRs are welcome for that!

daniel-ac-martin commented 2 weeks ago

@ray-marr-ho: Assuming that you are only using the components, as of v0.10.0, they should now work with React v18. I've not been able to upgrade this repo to React v18 yet though (I ran into hydration issues), so please let me know if you run into any problems.

ray-marr-ho commented 3 days ago

@ray-marr-ho: Assuming that you are only using the components, as of v0.10.0, they should now work with React v18. I've not been able to upgrade this repo to React v18 yet though (I ran into hydration issues), so please let me know if you run into any problems.

Thanks Daniel, it's still complaining on import. Which I think is because of the peerDeps in this file: https://github.com/daniel-ac-martin/NotGovUK/blob/master/packages/components/package.json

daniel-ac-martin commented 3 days ago

@ray-marr-ho: Sorry. Could you try v0.12.1? (Check the breaking changes listed against v0.12 and v0.11, although if you are only using the components, they may not affect you. - https://github.com/daniel-ac-martin/NotGovUK/releases )