search

daniel-ac-martin / NotGovUK

An implementation of the GOV.UK Design System in React that provides support for writing internal applications in addition to public ones.
https://not-gov.uk/
MIT License
27 stars 8 forks source link

BREAKING: Update react-helmet-async to v2 #1045

Closed daniel-ac-martin closed 2 months ago

daniel-ac-martin commented 2 months ago

Presumably this is a breaking change as it is a major version bump on a context providing package.

daniel-ac-martin commented 2 months ago

Tests failing; see: https://github.com/staylor/react-helmet-async/issues/208

Possible fix: https://github.com/staylor/react-helmet-async/pull/230

i.e: Likely to be fixed in v2.0.6

cypress[bot] commented 2 months ago

NotGovUK    Run #5372

Run Properties:  status check failed Failed #5372  •  git commit 4a4a79a053: Update package lock-file
Project NotGovUK
Branch Review react-helmet-async-v2
Run status status check failed Failed #5372
Run duration 12m 05s
Commit git commit 4a4a79a053: Update package lock-file
Committer Daniel A.C. Martin
View all properties for this run ↗︎
Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Tests for review