search

daniel-beckham / nasa-imagery-fetcher

Android app that fetches images from NASA's Image of the Day and Astronomy Picture of the Day services
Apache License 2.0
16 stars 4 forks source link

F-Droid inclusion #3

Closed Poussinou closed 4 years ago

Poussinou commented 5 years ago

Hi,

Since this app is Apache v2 licensed, are you considering the fact to add it to F-Droid? There is a strong community behind.

You can find some documentation here.

Otherwise, if you don't want to work on the inclusion of this app by yourself, would it be ok for you if someone else do it for you?

daniel-beckham commented 5 years ago

Feel free to submit it. I think the only issue is the API keys not being included in the repository, but I went ahead and made a small commit to add them just now (they're in the binary files anyway).

Let me know if you need help with anything.

Poussinou commented 5 years ago

What are the binaries you're talking about? The apks from the release section?

Anyway, F-Droid builds everything from source, so indeed we needed the API keys. I don't see any other showstoppers here, so I'm going to open RFP on F-Droid side.

daniel-beckham commented 5 years ago

Yeah, I just meant that it was already possible to get the API keys from the published binaries, so there was really no need to hide them in the source. The APIs themselves are free anyway.

Thanks for starting the process. There shouldn't be any issues with compiling now, but let me know if anything comes up.

Poussinou commented 5 years ago

Hum just a question, do you know if this APIs are free-as-in-freedom. If it's not the case, we can still build the app, but it will need a flag. Same question: what are the licenses of the pictures (Creative Commons?)

daniel-beckham commented 5 years ago

The APIs are free to use. They aren't tied to paid services. All that they're ultimately doing is getting the latest images from some NASA pages. I suppose that they're also open source, if that matters:

https://github.com/nasa/apod-api https://github.com/openaustralia/morph

The copyright/license information is probably going to vary with each image. That information should at least be available in the link to the NASA page where the image was obtained. These links can be accessed in the app.

Absolutely no assets from NASA are used in the source, though, so I don't think any kind of additional attribution is needed here.

daniel-beckham commented 5 years ago

@Poussinou Updates on this? I can try opening an issue on RFP later if you're busy right now.

Poussinou commented 5 years ago

Sorry, I was very busy the past week due to my final (very final) exams at school. It'll take a little bit more time.

Yes please, go ahead, open a new RFP, and try to write the corresponding yml file, and hopefully a packager will take care of this (it will be me if I have the time to do so).

daniel-beckham commented 4 years ago

@Poussinou Sorry this took so long. I was busy myself: https://gitlab.com/fdroid/rfp/issues/1190

Hopefully all goes well, but I'll keep an eye on that issue.

daniel-beckham commented 4 years ago

The app is now on F-Droid. 🙂