error - TypeError: Cannot read properties of undefined (reading 'map')

daniel-centore / uppy-next-s3-multipart

This is a library designed to make it simple to integrate the Uppy uploader library with AWS S3 Multipart Uploads while using a NextJS server

8 stars 1 forks source link

error - TypeError: Cannot read properties of undefined (reading 'map') #1

Open oalexdoda opened 1 year ago

oalexdoda commented 1 year ago

Hey @daniel-centore , trying to use your module for a Uppy Next.js setup. On upload, it always throws this error:

Any clue what it might be or how to debug it? All .env keys are set properly.

Thanks!

daniel-centore commented 1 year ago

I would go into .../uppy-next-s3-multipart/build/UppyNextS3MultipartEndpoint.js, go to prepareUploadParts, and add a console.log(partData) to see what's going on there

bnchdrff commented 1 year ago

This module is compatible with uppy v2 - using v3 will result in the error you're describing

daniel-centore commented 1 year ago

@bnchdrff that makes sense, didn't realize a new version had come out. I'm not actively working on this so if somebody wants to PR to fix it please feel free, otherwise I'll probably get to it eventually

oalexdoda commented 1 year ago

Hey @daniel-centore , any chance you can have a quick look to help put this on the right path? Thank you!

daniel-centore commented 1 year ago

@altechzilla For now either downgrade to Uppy v2 or put up a PR to fix this for v3. I made this library for a personal hobby project and released it just in case it was useful for others, I don't really have time to constantly maintain it. I will probably eventually fix it for v3 if nobody else gets to it first, but it could be many months.

oalexdoda commented 1 year ago

It’s okay, eventually switched from Uppy to Filepond which is a lot more stable and doesn’t require a companion server.

Handling uploads to AWS client side using signatures / PUT requests. Seems less of a headache considering all the issues Uppy has.

Thanks for the quick reply! You can close this issue if you wish to.

yocontra commented 1 year ago

@daniel-centore Any notes on updating this to work with uppy v3? My team can take a swing at it and send a PR if you point us in the right direction.

daniel-centore commented 1 year ago

@yocontra

UppyNextS3MultipartOptions.ts - This file overrides the implementations of the functions here: https://github.com/transloadit/uppy/blob/main/packages/%40uppy/aws-s3-multipart/src/index.js . This allows us to create our own non-Companion implementation. All of the functions overridable via the options param need to be overridden to call a NextJS endpoint instead, and these functions need to appropriately send any data to the NextJS endpoint which would otherwise have been sent to the Companion one.
UppyNextS3MultipartEndpoint.ts - This file is a re-implementation of the backend server, the source of truth for what to base this on is going to be from the companion server: https://github.com/transloadit/uppy/blob/main/packages/@uppy/companion/src/server/controllers/s3.js . These endpoints need to be reimplemented for NextJS instead.