daniel-cottone / serverless-es-logs

A Serverless plugin to transport logs to ElasticSearch
MIT License
54 stars 32 forks source link

Not working for other than Node.js runtimes #537

Open finkin opened 2 years ago

finkin commented 2 years ago

Since https://github.com/daniel-cottone/serverless-es-logs/pull/535 this plugin can't be used with runtimes other than Node.js

🐞 Problem I've been using this plugin for a long time in several functions written in Python without any issues (good job by the way!!). But since the last version, the function is being created with Python as the runtime, and it obviously doesn't work

🎯 Goal Restore the support for other runtimes than Node.js.

💡 Possible Solutions I don't see the point in inheriting the runtime, other than having to change Node version in two different places instead of one. Just reverting the change will be fine, however if the current behavior is valuable to someone, and you want to keep you can always check if the service runtime is Node.js first.